Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Conversation

@mmoreram
Copy link
Member

  • Deleted composer.lock from repository

- Deleted composer.lock from repository
@cv65kr
Copy link

cv65kr commented Sep 17, 2018

@mmoreram The same problem is with Apisearch\Url\UrlBuilder also require symfony/routing.
I think Events and UrlBuilder should be moved into apisearch-bundle. Client should be pure and universal without additional compontents. WDYT?

@mmoreram
Copy link
Member Author

@cv65kr moving urlBuilder to bundle, as we talked some weeks ago, seems good to me.
But events are part of the model. To be honest, I would prefer to maintain the events in the library (the library is requiring another PHP library, not a Symfony Framework environment piece).

@cv65kr
Copy link

cv65kr commented Sep 17, 2018

I just remind You :)
Your argument seems good to me

@hkulekci
Copy link
Contributor

hkulekci commented Sep 17, 2018

I did not get any error about UrlBuilder part. Is this normal? I am using to build Zend module, and I used HTTP repositories mostly.

Edit:

I guess UrlBuidler is for the only extension for twig. I agree about moving.

@mmoreram mmoreram merged commit 982cafd into master Sep 17, 2018
@mmoreram mmoreram deleted the fix/added-event-dispatcher-dep branch September 17, 2018 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants